NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Initialize cohort height during SP mode to use `EDPftvarcon_inst%hgt_min` #1064

Open glemieux opened 1 year ago

glemieux commented 1 year ago

During SP mode initialization, we currently initialize the cohort heights with a generic 0.5 overriding the local hite variable, which is set to EDPftvarcon_inst%hgt_min for non-SP mode runs: https://github.com/NGEET/fates/blob/4f41112365d5488b3b0b9e909a2914082217e3f1/main/EDInitMod.F90#L926-L934

Since we eventually update the cohort heights with the call to satellite_phenology which uses the incoming hlm_sp_htop value from the satellite phenology data (via the host land model), I don't think there is any reason to use the arbitrary 0.5 hardcoded value. We should try switching the init to using the hgt_min parameter.

See https://github.com/NGEET/fates/pull/1024#issuecomment-1669224595 for further discussion and context.