NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Fixed argument type declaration for the number of cwd pools in the litter mod #1121

Closed rgknox closed 1 year ago

rgknox commented 1 year ago

Description:

We had been identifying an argument "ncwd" as type(integer), which is kind of strange, probably something I wrote, but most compilers allowed it. Apparently AMD compilers do not like it. @ndkeen identified this and provided a prototype correction, here: https://github.com/E3SM-Project/E3SM/issues/6029 .

Collaborators:

@ndkeen

Expectation of Answer Changes:

none

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

Integrator

Documentation

no documentation required

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

glemieux commented 1 year ago

Running regression tests on Cheyenne.

glemieux commented 1 year ago

Regression testing on cheyenne is complete and all expected tests pass B4B.

Test results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1121-fates