Enable leaf phenology when running Static Stand Structure (ST3) Mode

mpaiao commented 11 months ago

Description:

Leaf phenology was by default disabled when running ST3 mode, which limits its application in deciduous-dominated area (e.g., when assessing fluxes given a stand). This pull request partially addresses this.

To avoid errors due to carbon checks, the code simply imposes retranslation factors = 1 to all tissues and elements, and thus sending all mass to storage. This also ensures all elements are available for regrowth with minimal edits to the code.
Limitations: this solution does not address the seasonal cycle of heterotrophic respiration, as the litter layer does not change in response to tissue abscission. That said, this is not making the seasonality representation worse, as the litter pools were already aseasonal in ST3.

Collaborators:

@ckoven @rgknox @rosiealice

Expectation of Answer Changes:

Results should change when running FATES in ST3 mode.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

[x] The in-code documentation has been updated with descriptive comments
[ ] The documentation has been assessed to determine if updates are necessary

Integrator

[ ] FATES PASS/FAIL regression tests were run
[ ] Evaluation of test results for answer changes was performed and results provided

Documentation

Technical Note update:
User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

rgknox commented 10 months ago

I think its fair to ignore heterotrophic seasonality, and litter fluxes. They were not there before, so we are not losing process functionality, only gaining processes functionality.

glemieux commented 10 months ago

Regression testing is queued on cheyenne.

glemieux commented 10 months ago

Regression testing is showing that the ST3 mode does not pass exact restart currently. Looking into this. All other expected tests are B4B.

NGEET / fates