Solvers for finding roots during stomatal conductance is being updated. This is just an alternative way of solving the same equation, these methods are ubiquituous. The NWSC method has an open use policy, the Sridharachary method is available as a fallback as well.
Functional unit tests have been added to evaluate the solvers.
Collaborators:
@glemieux
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
[x] The in-code documentation has been updated with descriptive comments
[x] The documentation has been assessed to determine if updates are necessary
Integrator
[x] FATES PASS/FAIL regression tests were run
[x] Evaluation of test results for answer changes was performed and results provided
fates test suite: OK, differences are expected for both methods and within reasonable tolerances. Also looked at 4 year 4x5 SP run and stomatal conductance differences are small between methods.
ekluzek
commented
8 months ago
Description:
Solvers for finding roots during stomatal conductance is being updated. This is just an alternative way of solving the same equation, these methods are ubiquituous. The NWSC method has an open use policy, the Sridharachary method is available as a fallback as well. Functional unit tests have been added to evaluate the solvers.
Collaborators:
@glemieux
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
fates test suite: OK, differences are expected for both methods and within reasonable tolerances. Also looked at 4 year 4x5 SP run and stomatal conductance differences are small between methods.