refactor of LAI-by-patch-age history (FATES_LAI_AP)

rgknox commented 8 months ago

Description:

This is a bug fix. The FATES_LAI_AP diagnostic did not seem to be written correctly. Also, the variables should match FATES_LAI, when summed over patch area weights.

FATES_LAI = sum( FATES_LAI_AP * FATES_PATCHAREA_AP)

Fixes: #1170 Fixes: #1183

Collaborators:

@samsrabin

Expectation of Answer Changes:

This should change both FATES_LAI and FATES_LAI_AP, and a new variable FATES_ELAI is now available.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

[x] The in-code documentation has been updated with descriptive comments
[x] The documentation has been assessed to determine if updates are necessary

Integrator

[ ] FATES PASS/FAIL regression tests were run
[ ] Evaluation of test results for answer changes was performed and results provided

Documentation

Technical Note update:
User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

samsrabin commented 8 months ago

Looks like this works for me! screenshot_0211

rgknox commented 8 months ago

I might also add the fix to #1170 into this, since it's also trivial

rgknox commented 6 months ago

tests ok on derecho, some diffs, and the diffs are related only to the changed output variables

NGEET / fates