Parameters duplicated in EDPftvarcon Receive_PFT()

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)

Other

105 stars 92 forks source link

Parameters duplicated in EDPftvarcon Receive_PFT() #1185

Open samsrabin opened 7 months ago

samsrabin commented 7 months ago

I happened to notice that at least the following parameters have fates_params%RetrieveParameterAllocate() called for them twice in the Receive_PFT() subroutine of EDPftvarcon:

fates_mort_scalar_coldstress
fates_mort_scalar_cstarvation
fates_mort_upthresh_cstarvation

Basically a non-issue, but I figured I'd document it.

mpaiao commented 7 months ago

Thanks for spotting it @samsrabin! I agree that we should remove duplicates.