search

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

History fields not calculated due to "history_dimlevel" are still output (as NaNs) #1214

Closed adrifoster closed 5 months ago

adrifoster commented 5 months ago

Seemingly, if you don't calculate a history field because of your dimlevel, we still write out the data, as NaNs. This is kind of confusing and I think we should turn off the hist_addfield for that variable if we don't actually calculate it.

@rgknox apologies if this was already discussed and I missed it!

rgknox commented 5 months ago

This should be the case (i.e. they should not be written), which variable(s) are not doing this? (hoping not all!)

adrifoster commented 5 months ago

Actually nevermind I think this might be an issue with a new variable we (@noahlb123 and I) were trying to make. sorry!

rgknox commented 5 months ago

phew.. (wipes sweat off brow) If you notice its a real bug, lets open this again and we will get it fixed.