search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Brackets and Spaces in DITA filenames (NHS D generated) #107

Closed maxChappell closed 4 years ago

maxChappell commented 4 years ago

The current pipeline utilises NHS D DITA files to grab converted title names for items. Sometimes, the routine isn't finding the topic - see person stated gender code (stop smoking) data element in mauro.

Suspect that this is because we had a limitation in the CMS re use of spaces and brackets in file names - so we replace with an underscore.

arkie-boy commented 4 years ago

So this is me asleep at the wheel. There is an error message in the generated SQL noting that some of the DITA nodes couldn't be found had I gone to look for it. I added the error handling code that generated the messages against this possibility.

A simple replace of '(', ')' and ' ' with '_' seems to have fixed all the instances - I have no DITA node error messages in my output file now.

Will be built into next release

maxChappell commented 4 years ago

for review

maxChappell commented 4 years ago

Fix to deliver knitted txaclass files and html will remove this issue.