NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Add all Terms isn't working when creating a Data Element CodeSet and Data Element #561

Open AngelaFaulding opened 2 months ago

AngelaFaulding commented 2 months ago

Peter - could you have a look at this issue and help please.

I am trying to create a new Data Element and CodeSet in CR8000: PERSON STATED EYE COLOUR. I have successfully created the Code Set and selcted all Terms:

image

However, when I look at the Data Element CodeSet, it is not showing any Terms. There was an issue with adding all Terms that you noted on one of our calls, did you fix this? This must be related to #544

image

I then tried to create the Data Element but when I try to submit the Data Element, I received the following. Can you please help to explain what I have done wrong?

image

pjmonks commented 1 month ago

Select "Add all terms" and it not working is an issue with Mauro itself, and should be raised to @jamesrwelch.

Your second issue, not being able to create the "Reference to CodeSet" whilst creating the Data Element - an existing reference already existed, but it referenced a Code Set which does not exist anymore. I think I had to manually fix something around this area for you before. I have removed all references to that old Code Set, you should now be able to follow your instructions to create a new Data Element again.

However, this raises another issue that @jamesrwelch must look into. When a "Reference to CodeSet" data type exists but the referenced model does not, you cannot use the UI to locate that data type anymore, I had to go into the database and manually delete it. The reason is because the UI which try to fetch the referenced model to display the label for it, but will return a 404 (obviously) which is handled badly.

Apart from where I have fixed the database for you @AngelaFaulding , I believe the rest falls out of scope for System C and needs to be picked up with @jamesrwelch.

AngelaFaulding commented 1 month ago

@jamesrwelch - re the above. I have created a new Attribute, Attribute Terminology, Data Element and Data Element Codeset in branch CR8008.

I added 7 terms to the Attribute Terminology: image

I selected "Add all Terms" to add all terms to the codeset.

When I view the codeset, there are no terms added:

image

The Orchestrator shows the Terms on the Attribute and none on the Data Element:

image

image

Peter did identify this as an issue a while ago when he showed us how to create a codeset, but has not resolved this and has now said it is an issue for you to resolve. Can you help please?

AngelaFaulding commented 1 month ago

James will investigate.

AngelaFaulding commented 3 weeks ago

16/10/24 - this is still not working:

image

jamesrwelch commented 4 days ago

Reopening as closed automatically by GitHub