search

NHSDigital / software-engineering-quality-framework

🏎️ Shared best-practice guidance & tools to support software engineering teams
145 stars 35 forks source link

ignoring link checking for Azure links and updating OWASP Zap link #308

Open walteck opened 11 months ago

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

regularfry commented 11 months ago

@walteck you might want this, which seems to be a bit more reliable. I'll be interested to see if it becomes intermittent over time.

Two observations at this point:

  1. We are tying correctness of our own changes to state we don't control. Someone else can make our pipeline break and that's not great. But also it's a check at a single point in time, where what we really want is continuous monitoring.
  2. The failures we have seen are false positives.