NIAEFEUP / uni

Mobile app designed to help students of the University of Porto to manage their academic life.

GNU General Public License v3.0

50 stars 18 forks source link

fix: app not closing on the exit dialog #1369

Closed peucastro closed 3 weeks ago

peucastro commented 4 weeks ago

Closes #1344 Fixes the issue in which the app doesn't close when the user presses "yes" on the "Do you really want to exit?" dialog.

https://github.com/user-attachments/assets/ace7b36a-e0d1-4bfc-b076-3b56eac78565

Review checklist

[ ] Terms and conditions reflect the current change
[ ] Contains enough appropriate tests
[ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
[ ] Properly adds an entry in changelog.md with the change
[ ] If PR includes UI updates/additions, its description has screenshots
[ ] Behavior is as expected
[ ] Clean, well-structured code

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (2ff5924) to head (930e0d7). Report is 20 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1369 +/- ## ======================================= - Coverage 12% 12% -0% ======================================= Files 266 266 Lines 7198 7201 +3 ======================================= Hits 803 803 - Misses 6395 6398 +3 ```

limwa commented 3 weeks ago

Well done! :tada: :rocket: