search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

any::rstac in pkgdown workflow #121

Closed mitchellmanware closed 3 months ago

mitchellmanware commented 3 months ago

rstac dependency in the test coverage portion of pkgdown deployment workflow

mitchellmanware commented 3 months ago

@sigmafelix

The pkgdown deployment when pull into the main branch is failing due to missing rstac dependency in the test-covr job. https://github.com/NIEHS/amadeus/actions/runs/10375868561/job/28726479014

The same issue was occurring for the test-coverage workflow in the 1.0.3 PR last week. First image shows run without any::rstac in the .github/workflows/test-coverage.yml and the second with it included (although tests still failed due to the calc_lagged issue, the failure is no longer due to rstac).

Screenshot 2024-08-14 at 8 35 28 AM (2) Screenshot 2024-08-14 at 8 35 31 AM (2)

I know we inactivated the olm functions from the main code base, but as they are still checked by the test-download_olm.R, test-process_olm.R and test-list_stac_files.R, it needs to be included for test-coverage and pkgdown workflows

sigmafelix commented 3 months ago

Got it. I'll approve the PR. Thanks.