Closed sigmafelix closed 3 days ago
This looks great, Insang. Thanks! I agree that version 1.2.0
is appropriate for such an update. Branch 1.1.4
was merged to main last week (https://github.com/NIEHS/amadeus/pull/141) (sorry for the confusing numbers, CRAN edits after branch creation caused version number differences), so the only suggestion would be to pull directly into main
.
@mitchellmanware Thank you for the quick reply! I will change the target to main
.
Hi @mitchellmanware, could you review this change for 1.2.0 candidate? I think this version is worth getting a version number of major update since we no longer support multithreaded calculation.
Major changes
future
andfuture.apply
dependency removed:calculate_modis_par()
andcalculate_nlcd()
future
dependency:nthreads
argumentcalculate_covariates()
fixedcalculate_modis_daily()
is moved to auxiliary and keywords were changed likewise (#137)