NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

1.2.0 candidate #144

Closed sigmafelix closed 3 days ago

sigmafelix commented 4 days ago

Hi @mitchellmanware, could you review this change for 1.2.0 candidate? I think this version is worth getting a version number of major update since we no longer support multithreaded calculation.


Major changes

mitchellmanware commented 3 days ago

This looks great, Insang. Thanks! I agree that version 1.2.0 is appropriate for such an update. Branch 1.1.4 was merged to main last week (https://github.com/NIEHS/amadeus/pull/141) (sorry for the confusing numbers, CRAN edits after branch creation caused version number differences), so the only suggestion would be to pull directly into main.

sigmafelix commented 3 days ago

@mitchellmanware Thank you for the quick reply! I will change the target to main.