search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

0.1.4 #35

Closed mitchellmanware closed 8 months ago

mitchellmanware commented 8 months ago
  1. roxygen descriptions (https://github.com/Spatiotemporal-Exposures-and-Toxicology/amadeus/issues/29)
    • Short description for references page and longer paragraph for function-specific pages
    • More detail in @return messages
    • Standard order of parameters for download, process, and covariate calculation functions
    • Example for returned list of dates for process_hms (https://github.com/Spatiotemporal-Exposures-and-Toxicology/amadeus/issues/9)
      1. Organized pkgdown "References" page (https://github.com/Spatiotemporal-Exposures-and-Toxicology/amadeus/issues/30)
    • Sorted into "Download", "Process", "Covariates", "Spacetime", and "Internal Functions"
    • @keywords internal for support functions
    • @keywords spacetime for spacetime functions
      1. data_download_acknowledgement -> acknowledgement
    • save user keystrokes but retain functionality
    • applied across download functions and unit tests
      1. Remove if (download) trigger from download_koppen_geiger() to increase code coverage
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.98%. Comparing base (667e3a2) to head (b2b9df3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 98.75% 98.98% +0.22% ========================================== Files 6 6 Lines 3050 3049 -1 ========================================== + Hits 3012 3018 +6 + Misses 38 31 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mitchellmanware commented 8 months ago

Closing to add process_merra2 and calc_merra2 functions.