NIIF / simplesamlphp-module-attributeaggregator

Attribute aggregator module for simplesamlphp
5 stars 6 forks source link

Missing installation instruction on Readme #8

Open malavolti opened 5 years ago

malavolti commented 5 years ago

SimpleSAMLphp: 1.16.3 (installed into /opt/simplesamlphp) OS: Debian 9 - Stretch AttributeAggregator module: installed through composer by following Readme file.
I saw that composer is not enough to enable the attributeaggregator module.

You have to copy the entire attributeaggregator directory from:

to:

or you will receive an error like this:

Exception: Could not resolve 'attributeaggregator:attributeaggregator': no class named 'sspmod_attributeaggregator_Auth_Process_attributeaggregator' or 'SimpleSAML\Module\attributeaggregator\Auth\Process\attributeaggregator'.

Thank you so much for this module!

szabogyula commented 5 years ago

I think, that the simplesamlphp/composer-module-installer didn't run properly. This module is responsible to copy the required module to the modules directory.

The expected response of the compser require command is like that:

Using version ^1.0 for niif/simplesamlphp-module-attributeaggregator
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Installing simplesamlphp/composer-module-installer (v1.1.6): Downloading (100%)         
  - Installing niif/simplesamlphp-module-attributeaggregator (v1.0.4): Downloading (100%)         
Writing lock file
Generating autoload files

and the module has to be in the modules directory. Does not it there?

I made a Dockerfile to reproduce the install process, and I didn't get this error, the module installed in the correct place, to /opt/simplesamlphp/attributeaggregator.

https://gist.github.com/szabogyula/16fe785575acdd21bd2bd2f7fbec96d1

Build it, and see the result:

docker build . -t sspaa
docker run  sspaa ls /opt/simplesamlphp/modules | grep attributeaggregator