search

NINAnor / ecosystemCondition

This repository is for documenting the design and calculation of indicators for ecosystem condition in Norway
https://ninanor.github.io/ecosystemCondition/
Creative Commons Attribution 4.0 International
0 stars 4 forks source link

Ndvi wetland joatop #120

Closed joatop closed 1 year ago

joatop commented 1 year ago

This pull request contains the ndvi-draft bookdown files for both wetland, seminat and natopen ecosystems. Knitting will probably take some time both the NiN and the NDVI (Sentinel, Modis & Landsat) files are quite large. I already upload the NiN- and NDVI data as rds-files from P to speed things up a bit.

anders-kolstad commented 1 year ago

I'm a little confused. Where is the DRAFT_ndvi_wetland.rmd file which was merged to main earlier. #53 @DrMattG

anders-kolstad commented 1 year ago

It take a while to render. I rendered the draft_natopen.rmd and put it here for reviewing: P:/41201785_okologisk_tilstand_2022_2023/temp/DRAFT_NDVI_natopen.html

joatop commented 1 year ago

@anders-kolstad I've gone through the comments and am done with the revision.

anders-kolstad commented 1 year ago

@joatop , before i merge into main, can you explain the purpose of the files under /R/NDVI/... . Are they superflous? For example, 1_data_handling.R writes multiple files to cache, which are read again in the actual chapter file. But the (same?) code for creating the cached data is also in the main chapter file, so I simply added the saveRDS() code in that file. And now there are two files writing the same cache file!

If the files under /R/NDVI/... are needed, please reference them (hypoerlink to them) in the main chapter file. Otherwise, delete them to make sure there is no duplicate code. Sorry if I messed up here.

Tagging @DrMattG also.

joatop commented 1 year ago

These files were my 'working files' in the beginning. I.e. I worked in standard R-files to start with and then stitched together the markdown files with code from these. And yes, these code-files create some cached files that then are loaded in the markdown. But if you included the saveRDS bits in the markdowns, then the markdowns should work on their own now, so I guess the working files could be removed from the repo if they are not wanted there anymore. The same applies to the FPI part...but I guess there the saveRDS bits are not included in the markdowns yet. I wanted to do a revision of those anyways and can include that. After that the FPI working files can be removed as well.

anders-kolstad commented 1 year ago

Ok, then I will remove those working files from the R/NDVI/ folder.

anders-kolstad commented 1 year ago

I renamed them instead as NDVI-old-working-files-DONT-USE