NIST-ISODB / isodb-library

Mirror of the NIST ISODB API (https://adsorption.nist.gov/isodb)
12 stars 3 forks source link

add formatters/validation via pre-commit/CI #5

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago

Start autoformatting and validating contents of the database

ltalirz commented 4 years ago

@dwsideriusNIST besides the formatters, I've started adding first validators in .github/validate.py. I think it will be quite easy for you to extend those with additional checks (just modify this file and the .pre-commit-config.yaml).

Note: The check for negative pressures turns up around ~100 isotherms with negative pressures: https://github.com/lsmo-epfl/isodb-library/runs/814328603#step:5:16

Perhaps these should be post-processed via your scripts once more?