search

NIST-ISODB / isotherm-digitizer-panel

Contribution form for NIST adsorption isotherm database implemented using pyviz panel
2 stars 3 forks source link

Feature read json #47

Closed ltalirz closed 3 years ago

dwsideriusNIST commented 3 years ago

I folded all the requested changes into the feature-read_json branch. I will address the question of which button to use for loading the input JSON (noted above). The other issue is that an error message was being shown in the "input json" area of the form.

ltalirz commented 3 years ago

Thanks @dwsideriusNIST , I'm happy to take it from here. Can you link somewhere the sample JSON files you were talking about (or perhaps make a separate PR to add them to the tests/static folder?)

ltalirz commented 3 years ago

Thanks, Dan. I will push your branch directly to the repository and keep working from there.

ltalirz commented 3 years ago

Superseded by https://github.com/ltalirz/isotherm-digitizer-panel/pull/52