NJACKWinterOfCode / Minimal_ToDo

A fully Material ToDo app with minimal features, just enough to be useful.
1 stars 6 forks source link

Add bottom navigation bar #14

Open rob729 opened 4 years ago

rob729 commented 4 years ago

Describe the feature you'd like Add the bottom navigation bar in the app.

Screenshots Screenshot_2019-12-15 UI Pattern Evolution — FAB-in-Bottom-Nav

Additional context Use the above image for the reference on how the design of the bottom navigation bar should be. On the left of the fab button, the option should be to display the ToDo list(all incomplete tasks) and on the right-hand side of the fab, the option should be to display the Completed ToDo list.

Would you like to work on the issue?

rajkumaar23 commented 4 years ago

@rob729 I would like to work on this. But does this issue include segregating the tasks too ?

rob729 commented 4 years ago

Yes. You need to display completed and not completed task separately.

rajkumaar23 commented 4 years ago

How would you like the separation to be done? Any ideas? In the adapter or having a separate livedata object?

rob729 commented 4 years ago

Currently, we are picking up all of the data from the database. So we can function in wordDao in which we can call a query to pick all the data where isComplete is false/true.

rajkumaar23 commented 4 years ago

Currently, we are picking up all of the data from the database. So we can function in wordDao in which we can call a query to pick all the data where isComplete is false/true.

Okay, sure.

rob729 commented 4 years ago

So are you working on this issue?

rajkumaar23 commented 4 years ago

So are you working on this issue?

Yes I’m.

rajkumaar23 commented 4 years ago

Is this layout fine ? Screenshot_20200104-224603_Minimal_ToDo

rob729 commented 4 years ago

@rajkumaar23 Try to have a bottom navigation similar to this instead of above screenshot.

rob729 commented 4 years ago

Is this layout fine ? Screenshot_20200104-224603_Minimal_ToDo

This is also quite good. Try to have the background of the bottom navigation little greyish so that it is different from the background.

rajkumaar23 commented 4 years ago

This is also quite good. Try to have the background of the bottom navigation little greyish so that it is different from the background.

Okay sure.

rob729 commented 4 years ago

You can also try to add elevation to the bottom navigation instead of color change. Try this one first.

rajkumaar23 commented 4 years ago

You can also try to add elevation to the bottom navigation instead of color change.

Yeah I'll try both and have the design that looks good finally.

rob729 commented 4 years ago

Ok

rajkumaar23 commented 4 years ago

Assign me this ?