NKI-AI / direct

Deep learning framework for MRI reconstruction
https://docs.aiforoncology.nl/direct
Apache License 2.0
228 stars 40 forks source link

Problems building docker image #191

Closed estenhl closed 2 years ago

estenhl commented 2 years ago

Unable to build the docker image on both Ubuntu and macOS due to what seems like multiple errors

To Reproduce

> docker build -t direct:latest .
Sending build context to Docker daemon  6.144kB
Error response from daemon: dockerfile parse error line 21: unknown instruction: &&

Fixed by adding backslashes to lines 20-24

 => ERROR [10/15] RUN jupyter notebook --generate-config                   0.3s
------
 > [10/15] RUN jupyter notebook --generate-config:
#14 0.259 /bin/sh: 1: jupyter: not found

Fixed by adding a line for conda installing jupyter

 => ERROR [14/15] RUN python -m pip install -e ".[dev]"                    1.2s
------                                                                          
 > [14/15] RUN python -m pip install -e ".[dev]":
#18 0.890 ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /direct

Wasn't able to get to the bottom of this one

Environment Operating system: Ubuntu 18.04.5 LTS Docker version: 20.10.14

and

Operating system: macOS Monterey 12.2.1 Docker version: 20.10.8

georgeyiasemis commented 2 years ago

Hi @estenhl, can you follow the instructions using conda (https://docs.aiforoncology.nl/direct/installation.html#install-using-conda), as we look into the above issue?

sairamgeethanath commented 2 years ago

@georgeyiasemis I think lines 20 through 24 are missing new line characters ()

RUN git clone https://github.com/mrirecon/bart.git /tmp/bart && cd /tmp/bart && make -j4 && make install && rm -rf /tmp/bart

estenhl commented 2 years ago

@georgeyiasemis Was able to install using the conda instructions :+1: @sairamgeethanath Yeah this seems right, was able to fix it by patching up that. Faced some further problems later in the Dockerfile though

Winnie-xwj commented 2 years ago

I have used the Conda instructions(https://docs.aiforoncology.nl/direct/installation.html#install-using-conda) and worker with Colab, but I have some problems in reproducing the experiment in their paper (Recurrent Variational Network: A Deep Learning Inverse Problem Solver applied to the task of Accelerated MRI Reconstruction (CVPR 2022)

截屏2022-05-03 下午9 07 14

Could you give me some advice?