search

NLeSC / LargeScaleImaging

Data, Software,Results and Publications for the Large Scale Imaging research @ NLeSc
Apache License 2.0
3 stars 0 forks source link

Test for binary_mask2ellipse_features #25

Closed elboyran closed 8 years ago

elboyran commented 8 years ago

There is an issue with testing the function. The order of labeling CCs is different in MATLAB and OpenCV which makes it very difficult to compare images with multiple regions in them. Few images with a single region each should be for testing. Also, fitting an ellipse is different in both platforms, we have to decide what is a tolerable difference- for now can be up to 2-3 pixels for a centroid -may be visualization will help deciding on it! Function and test is ready, but tests are failing, so are not committed.

elboyran commented 8 years ago

4 test images with single region in them prepared. Tested on 1 image. Finish all tests (incl. MATLAB results) and decide on what is acceptable tolerance, modify array comparison with a tolerance as parameter.

elboyran commented 8 years ago

Tests on 4 images ready. Still fail, though with not so large error (if regions almost elliptic). Need to verify using visualization weather the ellipses are acceptable!). Still need to decide on tolerance to make the tests pass.

elboyran commented 8 years ago

the tests for binary_mask2ellipse_features are passing now, but with abs.tolerance of 2 pixels- quite large! Visual checking is needed!

elboyran commented 8 years ago

To be dealt with in the Python repo.