search

NLnetLabs / routinator

An RPKI Validator and RTR server written in Rust
https://nlnetlabs.nl/projects/routing/routinator/
BSD 3-Clause "New" or "Revised" License
470 stars 71 forks source link

Store manifest number and check for regressions. #946

Closed partim closed 8 months ago

partim commented 8 months ago

This PR adds a check for manifest number regressions when validating a collected publication point. It stores the manifest number for each manifest and checks against it when collecting a new manifest. If the latter’s number has not increased, it falls back to the stored manifest. This behaviour is mandated by RFC 9286.

The PR changes the data stored for manifests and thus updates the StoredManifest version to 1. In order to avoid an endless stream of error messages after an upgrade, it downgrades the logged message when encountering an malformed StoredManifest to DEBUG.

Fixes #913.

DRiKE commented 8 months ago

Just wondering: any the longer term plan for the loglevel of that message? I imagine you'd actually want it to be INFO again at some point.

partim commented 8 months ago

We should probably collate these error messages into just one which then can be warn. There’s a vague plan to rework logging, so it should be done then.