search

NLnetLabs / rpki-rs

An RPKI library for Rust
BSD 3-Clause "New" or "Revised" License
40 stars 22 forks source link

Drop dependency on routecore. #261

Closed partim closed 1 year ago

partim commented 1 year ago

This PR drops routecore as a dependency and includes all the code from that crate we need for RPKI.

Having a shared dependency between the RPKI and BGP projects was a bit premature and the overlap is relatively small. Keeping things separate removes some administrative burden on the BGP projects during their early stages, so this seems the right move. We can always reconsider later.

The PR moves what used to be routecore::{addr, asn} to crate::resources::asn androutecore::bgpsec::KeyIdentifier to crate::crypto::keys::KeyIdentifier (where it was re-exported already previously).

partim commented 1 year ago

Good point. Let’s do this in a separate PR. I also want to update the base64 dependency which will probably result in a util::base64 module.

timbru commented 1 year ago

Good point. Let’s do this in a separate PR. I also want to update the base64 dependency which will probably result in a util::base64 module.

Sounds good! Then I can probably also remove krill's dependency on the base64 crate.