search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Fix fs #41

Closed RoyStegeman closed 1 year ago

Radonirinaunimi commented 2 years ago

Thanks! I will run a fit now.

Radonirinaunimi commented 2 years ago

So, the following interpolation requires the arguments to be at least 2 elements:

https://github.com/NNPDF/nnusf/blob/2464c0e82d761694057c411bd81c279ff9642df5/src/nnusf/sffit/scaling.py#L30

This poses a problem when generating predictions since we only generate predictions for one single $A$ . One then needs to somehow take this into account in the following functions https://github.com/NNPDF/nnusf/blob/c53ca4ec2e9374dbb00cb5f749bdaad2ab25da9c/src/nnusf/plot/fit.py#L152

https://github.com/NNPDF/nnusf/blob/c53ca4ec2e9374dbb00cb5f749bdaad2ab25da9c/src/nnusf/sffit/load_fit_data.py#L46-L48

or somehow fake it when extracting the unique values https://github.com/NNPDF/nnusf/blob/c53ca4ec2e9374dbb00cb5f749bdaad2ab25da9c/src/nnusf/sffit/scaling.py#L22

For the sake of just generating SF plots with the last fit, the latter seems to be the least amount of work. I'll see this in a bit but just wanted to update here.

RoyStegeman commented 1 year ago

I guess we won't need this anymore? If so, can it be closed?

Radonirinaunimi commented 1 year ago

I guess we won't need this anymore? If so, can it be closed?

Yes, indeed!