search

NOAA-CSL / MELODIES-MONET

MELODIES MONET - diagnostic tool for evaluating models against a variety of observations including surface, aircraft, and satellite data all within a common framework
https://melodies-monet.readthedocs.io
Apache License 2.0
21 stars 31 forks source link

Coding style for MELODIES-MONET #300

Open blychs opened 3 weeks ago

blychs commented 3 weeks ago

Hi all, I suggest taking some of the coding style from MONETIO. I think that just merging a run of Black and isort to format the code without modifying it would help. There is already a pyproject.toml file with the relevant configurations, but it hasn't been used. It will be a BIG PR though, since those coding guides have not been followed until now. It won't change the contents of the code, just the formatting, but it will require all of us working in branches to follow it. I believe that it will make it easier to maintain, and it would be consistent with MONETIO, and it will be helpful for the future if we get developers. I think that if we start getting more devs, it will really help. In the not to distant future, we should aim for full pre-commits as MONETIO has. Let me know your thoughts, @zmoon, @rschwant . Cheers Pablo

rschwant commented 2 weeks ago

Plan is to spend the next 3 months getting coding done for version 1 that people have already started. Then we will have a brief pause on coding development when we pull this in before version 1 occurs.