NOAA-EDAB / ecodata

A data package for reporting on Northeast Continental Shelf ecosystem status and trends.
https://noaa-edab.github.io/ecodata/
Other
31 stars 12 forks source link

Update ecodata with corrected comdat and species groupings #87

Closed BBeltz1 closed 10 months ago

BBeltz1 commented 10 months ago

Replaced old comdat datafile with Sean's final corrections. Herring data for 2022 was added. Solution for revenue errors was deployed.

Replaced old species_groupings file with new SOE24 groupings.

BBeltz1 commented 10 months ago

@andybeet corrections/updates to comdat and species groupings ready for review.

sgaichas commented 10 months ago

I built this but am not seeing a 2022 data point for planktivores (herring) when I plot the NE human dimensions rmd; not sure what I'm doing wrong?

sgaichas commented 10 months ago

In this comdat dataset max year for Planktivore NEFMC managed species - Seafood Landings is 2021; I think the herring landings integration didn't take

andybeet commented 10 months ago

@sgaichas i see that too now. looking over code. I did add Herring but must have then got dropped

BBeltz1 commented 10 months ago

@andybeet @sgaichas this pull now includes the most recent corrections sent by andy

sgaichas commented 10 months ago

I can see the 2022 NE planktivores now in the plots, thanks for the fix!