NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
75 stars 170 forks source link

[NCO Bug] WMO files should not include the job name in the filename #290

Open WalterKolczynski-NOAA opened 3 years ago

WalterKolczynski-NOAA commented 3 years ago

Jen Yang 2020-12-28 21:35:32 UTC Currently in both gfs v15 (current production) or gfs V16 (30 days parallel), some wmo files are with job name inside the file name, this would cause some inconsistency when job name change in the upgrade. Please fix this to remove the job name from the file name in the next upgrade.

Here is some example wmo file name that contain the job name (or partial job name): grib2.awpgfs036.003.gfs_awips_f036_1p0deg_00 grib2.awpgfs_20km_ak_f036.gfs_awips_f036_00 grib2.awpgfs_20km_conus_f036.gfs_awips_f036_00 grib2.awpgfs_20km_pac_f036.gfs_awips_f036_00 grib2.awpgfs_20km_prico_f036.gfs_awips_f036_00 xtrn.awpgfs036.211.gfs_awips_f036_00

com.wafs0036.gfs_atmos_wafs_f36_00 xtrn.wfsgfs0036.gfs_atmos_wafs_f36_00

Also, the ecflow scripts for the following awips scripts need to update to remove the line for the job definition. It should take the value from BSUB -J line.

post_processing/awips_g2/jgfs_awips_g2_fHHH.ecf (remove line :export job="jgfs_awipsf${fcsthrs}${cyc}" )

post_processing/awips_20km_1p0/jgfs_awips_fHHH.ecf (remove line; export job=jgfs_awipsf%FCSTHR%%CYC%)

Refs: Bugzilla #1155

aerorahul commented 1 year ago

@HuiyaChuang-NOAA Who should we assign this issue to?

HuiyaChuang-NOAA commented 1 year ago

@HuiyaChuang-NOAA Who should we assign this issue to?

I believe Jason has in mind that his new Fed hire (announced by Brian today) will take over GFS downstream packages. Jason will return to work next week and I will confirm this with him.

Huiya

GwenChen-NOAA commented 1 year ago

@WalterKolczynski-NOAA and @aerorahul,

Where to find the following scripts?

post_processing/awips_g2/jgfs_awips_g2_fHHH.ecf post_processing/awips_20km_1p0/jgfs_awips_fHHH.ecf

I don't see a post_processing subdirectory under global-workflow or a post_processing repository under NOAA-EMC. Please provide more details on this issue and the paths/links to the scripts.

Thanks, Gwen

aerorahul commented 1 year ago

@WalterKolczynski-NOAA and @aerorahul,

Where to find the following scripts?

post_processing/awips_g2/jgfs_awips_g2_fHHH.ecf post_processing/awips_20km_1p0/jgfs_awips_fHHH.ecf

I don't see a post_processing subdirectory under global-workflow or a post_processing repository under NOAA-EMC. Please provide more details on this issue and the paths/links to the scripts.

Thanks, Gwen

The master scripts located in https://github.com/NOAA-EMC/global-workflow/blob/develop/ecf/scripts/gfs/atmos/post_processing/awips_g2/jgfs_atmos_awips_g2_master.ecf https://github.com/NOAA-EMC/global-workflow/blob/develop/ecf/scripts/gfs/atmos/post_processing/awips_20km_1p0/jgfs_atmos_awips_master.ecf together with https://github.com/NOAA-EMC/global-workflow/blob/develop/ecf/setup_ecf_links.sh is used to create the above hour specific ecf job cards.

GwenChen-NOAA commented 1 year ago

Thanks, @aerorahul! So, you want me to remove Line 43 in https://github.com/NOAA-EMC/global-workflow/blob/develop/ecf/scripts/gfs/atmos/post_processing/awips_g2/jgfs_atmos_awips_g2_master.ecf, and Line 39 in https://github.com/NOAA-EMC/global-workflow/blob/develop/ecf/scripts/gfs/atmos/post_processing/awips_20km_1p0/jgfs_atmos_awips_master.ecf, correct?

There is another request to change the filename. What is the correct format of filename that should be used? Also, changing filename may affect downstream products ingesting the data files. Has that effect been considered?