search

NOAA-GFDL / FRE-NCtools

Tools for manipulating and creating netCDF inputs for FMS managed models
GNU Lesser General Public License v3.0
20 stars 28 forks source link

create `do_great_circle`, `do_create_xgrid_order1`, and `do_create_xgrid_order2` #255

Closed mlee03 closed 11 months ago

mlee03 commented 1 year ago

In this PR, do_great_clrcle, do_create_xgrid_order1, and do_create_xgrid_order2 functions have been created and is called in _setup_conserveinterp. Creation of these function cleans up the non-read portion of _setup_conserveinterp and will make the process of adding OpenACC directives easier. Future plans to combine do_create_xgrid_order1 and do_create_xgrid_order2 will be considered.

Remapping of scalar data from cubed-sphere to latlon grid with conserve_interp1 and conserve_interp2 methods have been tested on CPUs.

mlee03 commented 1 year ago

This PR is not ready. CI passes and the code compiles when generating the parallelized versions of fregrid, etc. But the code does not compile with nvc for a very good reason: an argument was not passed into a function. It's strange that nvc is the only compiler that caught this mistake?

mlee03 commented 1 year ago

PR is ready

mlee03 commented 11 months ago

@ngs333 ready for your review. Let me know if you want to meet up to discuss this PR for clarifications/problems, etc :)

ngs333 commented 11 months ago

@ngs333 ready for your review. Let me know if you want to meet up to discuss this PR for clarifications/problems, etc :)

OK Thanks this (and not #256) will be the next one I review.