This is preliminary PR for an additional POD, "Finite-amplitude Rossby Wave Diagnostics". The code could run through and produce the plots on HTML properly when lastly touched base with Jess #514 (latest commit from main in this PR: f69e745 ) , but it breaks after merging the recent commits. After discussing with my liason @yihungkuo , it seems easier on both sides for me to submit a preliminary PR to iterate (rather than fixing the issues on my own). I am therefore submitting this PR to kickstart the fix, with the understanding that the MDTF team is busy and will get back only when time allows.
Please let me know if I shall provide more information to fix this. On my side, the missing items include the (1) Detailed documentation and (2) predigest data, which do not affect the test of the code. I am still working with my collaborators to finalize them, hoping to get them ready by the end of this month.
Thanks in advance! 😄
How Has This Been Tested?
In my inputdata/ directory, I have the following files downloaded from GFDL portal:
[ ] My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
[x] The scripts are written in Python 3.11 or above (preferred; required if funded by a CPO grant), NCL, or R
[x] All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
[ ] I have made corresponding changes to the documentation in the POD's doc/ subdirectory
[x] I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
[ ] I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
[x] My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
[ ] I have provided the code to generate digested data files from raw data files
[ ] Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
[x] I have included copies of the figures generated by the POD in the pull request
[x] The repository contains no extra test scripts or data files
Generated plot generated from sample data GFDL-CM3_historical_r1i1p1.*.day.nc
The plots look like this (if changing the hyperlink "plot" to actual PNG images) - these are generated out of a small sample so the patterns are not representative:
Description
This is preliminary PR for an additional POD, "Finite-amplitude Rossby Wave Diagnostics". The code could run through and produce the plots on HTML properly when lastly touched base with Jess #514 (latest commit from main in this PR: f69e745 ) , but it breaks after merging the recent commits. After discussing with my liason @yihungkuo , it seems easier on both sides for me to submit a preliminary PR to iterate (rather than fixing the issues on my own). I am therefore submitting this PR to kickstart the fix, with the understanding that the MDTF team is busy and will get back only when time allows.
Please let me know if I shall provide more information to fix this. On my side, the missing items include the (1) Detailed documentation and (2) predigest data, which do not affect the test of the code. I am still working with my collaborators to finalize them, hoping to get them ready by the end of this month.
Thanks in advance! 😄
How Has This Been Tested?
In my
inputdata/directory, I have the following files downloaded from GFDL portal:model/GFDL-CM3_historical_r1i1p1/day/GFDL-CM3_historical_r1i1p1.ua.day.ncmodel/GFDL-CM3_historical_r1i1p1/day/GFDL-CM3_historical_r1i1p1.va.day.ncmodel/GFDL-CM3_historical_r1i1p1/day/GFDL-CM3_historical_r1i1p1.ta.day.ncI run MDTF with the following command and get all the plots successfully:
Checklist:
conda_env_setup.shGenerated plot generated from sample data
GFDL-CM3_historical_r1i1p1.*.day.ncThe plots look like this (if changing the hyperlink "plot" to actual PNG images) - these are generated out of a small sample so the patterns are not representative: