Determine locations where `dmod.communication.Response` subtypes use their `data` field like dictionaries

NOAA-OWP / DMOD

Distributed Model on Demand infrastructure for OWP's Model as a Service

Other

7 stars 15 forks source link

Determine locations where `dmod.communication.Response` subtypes use their `data` field like dictionaries #360

Open aaraney opened 1 year ago

aaraney commented 1 year ago

Prior to #331, dmod.communication.Response's data field was an Optional[dict]. Post #331, dmod.communication.Response's data field is an Optional[dmod.core.Serializable]. The majority of instances where data fields were accessed or used as dictionaries were refactored in #331, however there may still be places that have not been updated. This issue serves to report where those bugs exist.

Related to #347.

aaraney commented 1 year ago

ModelExecRequestClient: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/communication/client.py#L910
ModelExecRequestResponse: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/communication/maas_request/model_exec_request_response.py#L91-L92 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/communication/maas_request/model_exec_request_response.py#L109-L110
- These are lesser offenders, but we should remove this logic in the future.
TestNWMRequestResponse: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/test/test_nwm_request_response.py#L116 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/test/test_nwm_request_response.py#L133 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/test/test_nwm_request_response.py#L141 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/communication/dmod/test/test_nwm_request_response.py#L152
IntegrationTestNWMRequestHandler: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py#L347 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py#L371 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py#L447 https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/lib/externalrequests/dmod/test/it_model_exec_request_handler.py#L467
JobRequestClient: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/gui/MaaS/client.py#L122
EditView: https://github.com/NOAA-OWP/DMOD/blob/600bfc89dfd52c5ccd4fc24a3af55de10183547c/python/gui/MaaS/cbv/EditView.py#L96