search

NOC-MDP / issue-tracking--polpred_offshore

Public repository for the discussion of issues and improvements for the NOC's Polpred Offshore Web Application
0 stars 0 forks source link

Improve/Fix error response messages #28

Closed androdnoc closed 4 years ago

androdnoc commented 4 years ago

No error dialog is returned when attempted computation comes back unsuccessful. Current implementation was only meant to be temporary. Error dialog needs to be rebuild and reimplementated.

Current Error response: There are no selected licences applicable

Error response and dialog from previous iterations:

image image

androdnoc commented 4 years ago

Legacy Comments from #24

thopri commented 2 hours ago

When using the portal, I have noticed that if I select an point that is not covered by a model but is covered by a license. Example attached, the red point is actually outside the model domain.

Screenshot 2020-07-14 at 08 10 06

The portal returns a message saying no license applicable, which while true is confusing as its clearly inside the license area. So a better response would be to say outside of model domain. And ideally provide option to display model grid as an overlay.

API handles it by saying outside of model domain or on land so doesn't need any changes.

androdnoc commented 10 minutes ago

Thanks for pointing this out.

What should be the case and has been the case in previous builds is that the dialog displaying There are no selected licences applicable is grouped with a View More button. which opens a dialog specifying the error. This implementation has been used as there will be cases where users try to make a prediction where none of their multiple licences are applicable, and so an multiple errors for each individual licence need to be shown.

This will be added back in in the next wave of fixes.

androdnoc commented 4 years ago

Added and ready to push in next wave of updates