NREL / OpenOA

This library provides a framework for assessing wind plant performance using operational assessment (OA) methodologies that consume time series data from wind plants. The goal of the project is to provide an open source implementation of common data structures, analysis methods, and utility functions relevant to wind plant OA.

https://openoa.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

194 stars 63 forks source link

refactor code for better readability and using more pythonic convention #155

Closed abbey2017 closed 3 years ago

abbey2017 commented 3 years ago

Main Issues

Code readability can be improved.
PEP 8 style compliance can be enhanced according to project contribution guidelines.
Raise overall coding standard of project.

Implementation

Refactored boolean comparison and singleton check implementation in code.
Removed trailing white spaces.
Shorten length of some lines without reducing readability.

Remarks

All tests passed after code refactoring.

jordanperr commented 3 years ago

Hi @abbey2017. Thank you so much for another pull request and for your contribution to OpenOA! This looks like a major change, and I am hesitant to merge without first discussing the changes. Would you please open up an issue in the OpenOA issue tracker. Please describe the issue you're fixing with this pull request in some more detail, including the tool you're using to update the code style and the configuration you're using in that tool. Please mention this pull request in your new issue.

Additionally, please update the base branch of your pull request to NREL:develop.

Once again, thank you so much for this contribution!

codecov-commenter commented 3 years ago

Codecov Report

Merging #155 (6e59ca8) into develop (6bed784) will not change coverage. The diff coverage is 89.18%.

@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    70.26%   70.26%           
========================================
  Files           23       23           
  Lines         1584     1584           
========================================
  Hits          1113     1113           
  Misses         471      471

Impacted Files	Coverage Δ
operational_analysis/methods/electrical_losses.py	`90.80% <89.18%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bed784...6e59ca8. Read the comment docs.

RHammond2 commented 3 years ago

Thanks again, Abiodun, for calling this inconsistency to our attention, it's greatly appreciated. I'm closing this PR, now that the larger PR has been merged.