Closed RHammond2 closed 2 years ago
Hi @RHammond2, I'm just going to leave my comments on 00_intro_to_plant_data.ipynb
and project_ENGIE.py
here too. Thanks for putting in the effort to translate all these preprocessing steps over to the v3 workflow!
00_intro_to_plant_data.ipynb
PlantData
object is and how it is used in OpenOA (e.g., organizing data, the main analysis methods in OpenOA operate on a PlantData object, etc.). To clarify the workflow I think it would also be helpful to first show how a PlantData object can be instantiated using data frames or csv files (maybe just as a comment in the notebook), then explain that in practice there are typically steps that need to be taken to clean the data and convert the data into the format required by PlantData . We describe the steps required for the LHB data, but not all of these steps may be required for other plants and other wind plants may require additional steps, depending on the data quality. We could also mention that we implemented these preprocessing steps for the example data in a project_ENGIE module, but the user can decide how they want to implement the preprocessing.WindToolKitQualityControlDiagnosticSuite
can only be used for US-based wind farms because the WIND Toolkit wind data it uses are only available for the US.qa.describe
for both cases, to save spaceix_consecutive = (scada_df_tz.loc[single_turbine_ix].Va_avg.diff(1) != 0)
: won't this actually be returning non consecutive data? Shouldn't the !=
be ==
? Same comment in the next cell qa.dalyight_savings_plot
: typo in "daylight" print(PlantMetaData.__doc__)
: There's some other metadata we probably want to include in PlantMetaData, like plant capacity and number of turbines. project_ENGIE.py
This PR adds a
.to_save()
method toPlantData
to ensure that users can easily save their validated data to file and use it again later. The 00 Intro notebook has also been updated to demonstrate how to use the method.This should wait for #192 and #193 to be merged as it's based on the changes from those pull requests