NREL / OpenOA

This library provides a framework for assessing wind plant performance using operational assessment (OA) methodologies that consume time series data from wind plants. The goal of the project is to provide an open source implementation of common data structures, analysis methods, and utility functions relevant to wind plant OA.
https://openoa.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
194 stars 63 forks source link

Documentation/00 update #199

Closed RHammond2 closed 2 years ago

RHammond2 commented 2 years ago

This addresses the comments from #194 and therefore closes #195.

Changes:

@ejsimley this review could either be a more detailed review, or a shorter review that ultimately gets brought back up in a comprehensive review of our examples and documentation. In either case, this PR isn't holding up other processes, so you're welcome to take your time with it now.

RHammond2 commented 2 years ago

@ejsimley This should fix up the remaining errors in the code and language in the notebook. I just removed the offending comment line for "create additional turbine objects" because that is a remnant from whoever originally wrote the notebook and it didn't seem to mean anything to me. You'll notice an error in the last section, which I believe is addressed in #198, and if not I'd like to address it separately anyway in a small PR.

ejsimley commented 2 years ago

@RHammond2, the documentation looks great now. I think this is fine to merge whenever you're ready. A couple points to consider, though are:

RHammond2 commented 2 years ago

@ejsimley, thanks for catching the typo and all of the other thoughtful comments along the way! As for capacity, that's included in #200, but I forgot to mention that in my previous comment.

I'm thinking that I fixed the underlying issue causing the what you're seeing the last comment in #198, so I'd like to test that out after this PR is merged, and address it in its own PR where the changes aren't coming from many directions.