Closed RHammond2 closed 1 year ago
I validated this PR by reading the code, merging it with entralliance/OpenOA/from_entr_connectorentralliance:feature/from_entr_constructor and running the electrical losses and AEP notebooks, and also running the plantdata_validator regression tests locally. It looks good to me.
Tests are failing due to known issue https://github.com/NREL/OpenOA/issues/228
This PR fixes a series of small bugs in the validation logic of
PlantData
:PlantData.asset
isNone
PlantData.calculate_asset_geometries()
for users that add asset data post-validationNone
is inPlantData.analysis_type
in addition to other values, that the error raising step is not skippedCloses #233
Thank you @jordanperr for identifying that there were a series of related issues when only some data is provided to
PlantData
!