search

NREL / OpenOA

This library provides a framework for assessing wind plant performance using operational assessment (OA) methodologies that consume time series data from wind plants. The goal of the project is to provide an open source implementation of common data structures, analysis methods, and utility functions relevant to wind plant OA.
https://openoa.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
194 stars 63 forks source link

Typo in readme #294

Closed williamhobbs closed 6 months ago

williamhobbs commented 6 months ago

Fixed typo, renalysis -> reanalysis in the install instructions that could cause problems for users.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

RHammond2 commented 6 months ago

Thanks @williamhobbs for finding this typo! Would you be able to just sign the CLA?

williamhobbs commented 6 months ago

I just signed the CLA. Let me know if anything else is needed.

williamhobbs commented 6 months ago

Cool!

For future reference, we typically we wouldn't merge this directly to main...

Just so I know, would there have been a better way for me to submit this? I didn't even think to check for other branches like https://github.com/NREL/OpenOA/tree/develop - is that where it should have gone?

RHammond2 commented 6 months ago

For features, bug fixes, etc. we'd typically favor the develop branch. However, patches sit in a weird place, where sometimes we'll go directly to main, and this PR happened to fall into that realm, so it's totally fine. I also had a lingering patch I forgot about so I incorporated them both into a patch release just now anyway.

RHammond2 commented 6 months ago

And also, feel free to checkout our contributing guide on the documentation. Though I'm realizing we're not very explicit about where branches should be merged to, so I'll address that and the miniconda licensing at the same time.