PAT, File Menu - Export XML Report is not making "qaqc.xml" file on installed version of OpenStudio 1.0

[DavidGoldwasser]

This doesn't seem to be affecting build versions. It is happening on Mac and Windows.

Elaine has a proposed change to CreateQAQCXML.rb to add the following line.

OpenStudio::Application::instance().application()

This worked on Windows, but not Mac. Dan thinks that following code in FileInfo.hpp is the issue.

const FileInfo &getLast(const boost::function<bool (const FileInfo &)> &f) const
{
  std::vector<openstudio::runmanager::FileInfo>::const_reverse_iterator itr 
    = std::find_if(m_files.rbegin(), m_files.rend(), f);

  if (itr != m_files.rend())
  {
    return *itr;
  }

  throw std::runtime_error("FileInfo not found");
}

[DavidGoldwasser]

I should be able to link an issue to a line of code, and I should be able to mention people. Not sure how to do either yet.

[axelstudios]

Looks like it's only working out of the box on Ubuntu. And Windows and OS X will each need separate workarounds.

[lefticus]

@DavidGoldwasser Use the "@" to link to someone, it will autocomplete people on the team. To link to code you can at least do a direct link: https://github.com/NREL/OpenStudio/blob/master/openstudiocore/src/runmanager/lib/FileInfo.hpp#L297-L308

Regarding the bug, I have no idea why @macumber would think that there is a bug in that code without more context for why. If the File being searched for doesn't exist... it doesn't exist.

[DavidGoldwasser]

Thanks @lefticus . I had thought there was something with a two way link (If anyone opened that code they would see a flag pointing to the bug, but it looks like that is not the case). I did find this really nice link on using issues. When you make a commit related to a bug you can type working on #2 or fixed #2 in the commit message and it will add to bug discussion and close status if specified. @axelstudios I assume you want to put info about referencing issues in commits in the documentation.

https://github.com/blog/831-issues-2-0-the-next-generation

[macumber]

@lefticus Andrew had a test script that was attempting to open a PAT project (that would open in PAT) but when trying to open from the script was crashing with the run time error "FileInfo not found". That was the only thing I could figure out, I don't know the call stack for when the error was raised other than it started with SimpleProject.open.

[lefticus]

So the question is, what file was it expecting to find and why wasn't it found?

[DavidGoldwasser]

@asparke2 thinks this is working now. I'll test on non dev mac and either close or add to Pivotal.

[DavidGoldwasser]

@asparke2 I tested on non Dev mac with 1.0.4, it only makes the results.xml, and not qaqc.xml.

[DavidGoldwasser]

Looks like @asparke2 accepted this mid October but the issue just had not been closed.