NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
495 stars 190 forks source link

Calibration Report Does Not Show Up if No Natural Gas Bill in Model #788

Closed asparke2 closed 10 years ago

asparke2 commented 10 years ago

If you have a model without a Natural Gas bill, the calibration report does not show up because of a JS error. Here is what the html looks like without a natural gas bill:

var consumption = {
    "Electricity Consumption":{
        "units":"kWh",
        "cvrsme":"151.22",
        "nmbe":"-153.25",
            "data":{
                "Start":["5/1","6/1","7/1","8/1","9/1","10/1","11/1","12/1"],
                "End":["5/31","6/30","7/31","8/31","9/30","10/31","11/30","12/6"],
                "Actual":[6306.5,5683.3,5518.3,5368.8,5575.8,5596.5,5859.5,1532.0],
                "Model":[13730,13208,14685,13872,13222,13337,12334,2620],
                "NMBE":[117.72,132.41,166.11,158.38,137.13,138.31,110.50,71.03]
        }
    },
    "Electricity Demand Consumption":{
        "units":"kWh",
        "cvrsme":"151.22",
        "nmbe":"-153.25",
            "data":{
                "Start":["5/1","6/1","7/1","8/1","9/1","10/1","11/1","12/1"],
                "End":["5/31","6/30","7/31","8/31","9/30","10/31","11/30","12/6"],
                "Actual":[0,0,0,0,0,0,0,0],
                "Model":[37,37,37,37,37,37,37,37],
                "NMBE":[0,0,0,0,0,0,0,0]
        }
    },
    "Natural Gas Consumption":{
        "units":"therms",
                "Start":],
                "End":],
                "Actual":],
                "Model":],
                "NMBE":]
        }
    }
};
macumber commented 10 years ago

@evanweaver Did the fix for this actually make it into develop? I am still seeing this in 1.2.3. Where is the commit where this was fixed? Also, did you make the change to show other fuel types as well? I think Monterrey demonstration has steam although I don't know if it is metered.

@asparke2 FYI

evanweaver commented 10 years ago

@macumber @asparke2 The pull request that I made for branch 63758008_CalibrationNoGas is still outstanding.

macumber commented 10 years ago

Ok, that pull request is on the measures branch so I guess that needs to be merged to master on measures and then those measures need to get put on develop. Looking at the commits it doesn't look like the measure handles fuel types other than gas or electric, is that right?

asparke2 commented 10 years ago

Tested this with 1.3.0 and it's fixed.