search

NREL / SAM

System Advisor Model (SAM)
BSD 3-Clause "New" or "Revised" License
318 stars 136 forks source link

Provide losses to PV Smoothing, and add UI warnings to increase alignment with gen #1065

Open brtietz opened 2 years ago

brtietz commented 2 years ago

PV smoothing still has some discrepancies between PV Smoothing Outpower (the output used to calculate violations) and System Power Generated (the final power output of the simulation). A major cause of this is that losses are not provided to the PV Smoothing algorithm. In the defaults case, this causes a constant, 1% difference in output power.

There are two other inputs that need to be set properly for these outputs to align. The user should get warnings to prevent issues: • The “minimum time at charge state” input on the dispatch page being shorter than the ramp interval • If simulating a DC connected battery, the inverter efficiency cutoff could cause trouble.

brtietz commented 1 year ago

Best to do https://github.com/NREL/SAM/issues/1146 first, so that we can do stronger output comparisons while solving this issue. Moving to patch 1.