NREL / buildstockbatch

Other
22 stars 14 forks source link

remove always-added reporting measure from Comstock #399

Closed eringold closed 1 year ago

eringold commented 1 year ago

SimulationOutputReport was being added to the comstock workflow by default, as well as when specified in the yml. This removes the default addition: SimulationOutputReport must be specified in the yml to be included in the workflow.

Eyeballing from my recent profiling of a 10k run shows the second instance of SimulationOutputReport taking roughly 10% of the total workflow runtime.

github-actions[bot] commented 1 year ago

File Coverage
All files 84% :white_check_mark:
base.py 89% :white_check_mark:
eagle.py 79% :white_check_mark:
exc.py 57% :white_check_mark:
local.py 50% :white_check_mark:
postprocessing.py 84% :white_check_mark:
utils.py 96% :white_check_mark:
sampler/base.py 79% :white_check_mark:
sampler/downselect.py 33% :white_check_mark:
sampler/precomputed.py 93% :white_check_mark:
sampler/residential_quota.py 61% :white_check_mark:
test/test_docker.py 33% :white_check_mark:
test/test_validation.py 97% :white_check_mark:
workflow_generator/base.py 90% :white_check_mark:
workflow_generator/commercial.py 53% :white_check_mark:
workflow_generator/residential_hpxml.py 84% :white_check_mark:

Minimum allowed coverage is 33%

Generated by :monkey: cobertura-action against 9cc96c5a8bd8bf90f0c5b598cf5175dd91087783

eringold commented 1 year ago

Thanks @nmerket, I've updated the changelog.