search

NREL / buildstockbatch

Other
21 stars 14 forks source link

Small refactor to simplify adding a GCP implementation #409

Closed nweires closed 11 months ago

nweires commented 11 months ago

Move a few things out of aws.py that will be reused in a GCP implementation, to keep future changes simpler.

nmerket commented 11 months ago

It seems our CI is failing because it's expecting PRs from within this repo and some of the actions don't have the correct permissions. Don't worry about that too much for now. I'll see if I can sort out a way to make that work before merging it down.

nweires commented 11 months ago

@nmerket Are you okay with merging this now? Or do you want to work on getting the checks to pass first?

nmerket commented 11 months ago

Yeah, I can merge this. It looks like the issues we're seeing is a known issue with PRs from a fork for one of the actions we're using. It's not that important and it looks like all tests are passing otherwise. However, If you have any suggestions on how to make github happy with this, I'm all ears.