Closed lathanh closed 10 months ago
File | Coverage | |
---|---|---|
All files | 86% |
:white_check_mark: |
base.py | 90% |
:white_check_mark: |
exc.py | 57% |
:white_check_mark: |
hpc.py | 78% |
:white_check_mark: |
local.py | 70% |
:white_check_mark: |
postprocessing.py | 84% |
:white_check_mark: |
utils.py | 91% |
:white_check_mark: |
cloud/docker_base.py | 89% |
:white_check_mark: |
sampler/base.py | 79% |
:white_check_mark: |
sampler/downselect.py | 33% |
:white_check_mark: |
sampler/precomputed.py | 93% |
:white_check_mark: |
sampler/residential_quota.py | 61% |
:white_check_mark: |
test/shared_testing_stuff.py | 85% |
:white_check_mark: |
test/test_docker.py | 33% |
:white_check_mark: |
test/test_validation.py | 97% |
:white_check_mark: |
workflow_generator/base.py | 90% |
:white_check_mark: |
workflow_generator/commercial.py | 53% |
:white_check_mark: |
workflow_generator/residential_hpxml.py | 86% |
:white_check_mark: |
Minimum allowed coverage is 33%
Generated by :monkey: cobertura-action against eccb93319ff2707c61fb85dc8ce417cfe4fb3acc
I still would like to see these PRs getting entries in the changelog, so we can track when these things go in.
Sure; done!
Pull Request Description
Use inversion of control in docker_base so that it can more strongly and easily ensure consistency between various implementations (GCP implementation to come).
This also includes teasing apart the several batch prep steps (weather, assets, and jobs) into their own methods so they can each be more easily understood, shared, and maintained.
Checklist
Not all may apply
test_docker_base.py
passesminimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle