search

NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Simulation time recorded as NaN in upgrade summary files #118

Closed daniel-thom closed 2 years ago

daniel-thom commented 2 years ago

The upgrades module records np.NaN as the initialization value for simulation time. This shows up in the Initial Stage, which seems a bit odd. Would 0.0 or null/None be more appropriate? Does it even belong here since it doesn't really apply to the Initial Stage?

ann-sherin commented 2 years ago

Yes, it doesnt apply to the "Initial" stage, but because initial and final have the same fields, I put it in there. We could initialize it to 0, if that's fine. Or any of the ones you mentioned.

Maybe None makes sense, but then it will change the field type of the column?