search

NREL / disco

DISCO
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Consider renaming image files #121

Open daniel-thom opened 2 years ago

daniel-thom commented 2 years ago

The upgrades module produces image files where the number of violations is embedded into the filenames. For example:

Bus violations before voltage upgrades_16.pdf
Bus violations after voltage upgrades_0.pdf

I recommend not doing this because it makes the filenames unpredictable. Imagine that there is a post-processing script that aggregates images. It would have to use pattern matching. The number of violations is recorded elsewhere.

Also, consider not using spaces in the filenames. It could just be me, and if so, please ignore, but it makes it more difficult to process the files in a shell.

ann-sherin commented 2 years ago

Agree on not having spaces in name. I did make that change today already when I was running for other cases.

On having number of violations in names: I like the fact that I can look at a name, and know how many violations are there - I'm tempted to keep them. But if we aggregate them, I guess it wont matter what the name is as long as the title of the image has that information I guess. It's just so we have all the information we need in the image.

daniel-thom commented 2 years ago

This issue will be obsolete once we put all images in the same file.