NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

Finish FlascDataFrame (Paul) #215

Closed paulf81 closed 1 month ago

paulf81 commented 1 month ago

Finish FlascDataFrame

Type Hints

This PR goes through code and updates type hints and docstrings where pd.Dataframe is called for and adds the option for FlascDataFrame to be used as well to clarify code docs.

Note code mostly updates existing type hints, but where type hints aren't used updates docstrings. Getting to uniform type hinting and type hinting style can be a future project

Remove time requirement

Removes requirements time column is included, as this will necessarily be violated in certain conditions

Add test of FlascDataFrame driving energy ratio

Add a test that initiating an energy ratio analysis with FlascDataFrame is ok

Add test FlascDataFrame driving time operations

Add. to df_time_operations_test.py some additional testing ensuring matching results when using FlascDataFrame as input