Open shorowit opened 7 years ago
We also will want illuminance maps, can wait to do those later if not of interest for res
@shorowit can you add some details when you get a chance about how each of these other components should look?
For example, daylighting controls required showing the distance to the nearest window interactively, and windows offered some options to decide placement (repeating, wwr, or single) and size. Here are my guesses:
I'm happy to look at implementing this but look like we need some more clarity here. @DavidGoldwasser
PV Panels and Skylights should work differently. Skylights are essentially windows on the roof (ie laid flat on the grid, instead of being attached to an edge). PV panels can have an independent tilt.
That is, unless we want to only support flush-mounted panels for now. But I don't believe roof pitch is currently implemented(?), so the panels could only be laid flat, which would poorly represent any actual PV array.
The most important parameters for a PV panel are its Tilt, Azimuth, and Length x Width All of these parameters would likely need to be specified in the Options UI
I actually used to work in commercial solar, and all of our panels were 1.6m x 1m (64.5in x 39in), however a quick look online indicates that there is some variation in size.
I'd suggest the following:
Placing panels one by one sounds like a pain and creates opportunity for errors (placing them too close or too far apart could cause overlap or gaps). They're almost always laid in long rows, so it would be really useful to include a "Number of panels in row" parameter as well. You could then multiply the Panel Width by the number of panels in a row. If you wanted a different number of panels in another row, you'd need to create a different "Panel Definition", akin to creating another "Window Definition" currently, when changing the width of a window. This would give Drawn_Width = Panel_Width*Numer_of_Panels
@Mkellyeng thank you for the in-depth response. I'll speak with @bgschiller to see where to start on this.
Once https://github.com/NREL/openstudio-geometry-editor/issues/17 and https://github.com/NREL/openstudio-geometry-editor/issues/210 are implemented, we can add: