NREL / floris

A controls-oriented engineering wake model.

http://nrel.github.io/floris

BSD 3-Clause "New" or "Revised" License

215 stars 156 forks source link

Set ref wind height to -1 for turboparkgauss.yaml #999

Closed paulf81 closed 1 month ago

paulf81 commented 1 month ago

Set ref wind height to -1 for turboparkgauss.yaml

Doing some other work I noticed that among the example inputs turboparkgauss.yaml uses 90.0 instead of -1. This isn't really a bug, but since we often use these example inputs as starters for other turbine models, probably nice if they all use the more generic option. I think this is the only case of this (the multiple turbine input correctly specifies the height since there isn't a single height).

paulf81 commented 1 month ago

I agree with this. I'll also use this opportunity to call out the tangentially related #809, which I'm going to update for v4.

Sounds good! Should I hold this PR and wait for that? Or go ahead and merge?

misi9170 commented 1 month ago

@paulf81 good to merge