NREL / rdtools

PV Analysis Tools in Python
https://rdtools.readthedocs.io/
MIT License
146 stars 61 forks source link

Release/2.1.6 #379

Closed mdeceglie closed 11 months ago

mdeceglie commented 11 months ago
kandersolar commented 11 months ago

I notice that PyPI rejected the automatic wheel upload, seemingly due to the package's version number not being determined correctly (0+untagged.1). Since version numbers are derived from git tags, I guess the issue is that the 2.1.6 tag was not present in the git repo clone used in the distribution build job. It seems that the job checked out the tagged commit, but was not aware of the tag itself. See this line in the 2.1.6 deploy job, compared with the same in the 2.1.5 job.

So I think that's the problem, but I'm not sure how to fix it for future deployments. git pull --tags or similar might be helpful, but I don't know why this would be needed now when it wasn't needed for 2.1.5. The release seems properly associated with the 2.1.6 tag to me. In any case, looks like the 2.1.6 distribution files need to be built and uploaded to PyPI manually.