NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Possible dangerous behavior manipulating CF in reV-offshore #324

Closed grantbuster closed 3 years ago

grantbuster commented 3 years ago

Why this feature is necessary: reV-Offshore calculates spatially-dependent loss values and then applies them to GCF values in the generation files. If you had to rerun reV-offshore you would doubly apply the loss factors. This could artificially reduce CF values and go unnoticed. This behavior does not cause an error.

A possible solution is: Either:

  1. Save raw cf_mean and cf_profile data to gcf_mean and gcf_profile datasets then have offshore look for these as default inputs.
  2. Cache raw generation outputs in a sub dir similar to collection (less effective)

I have considered the following alternatives: Just be careful

Charge code Maybe current wave charge code: WAPP 10343 16.01.05

Urgency / Timeframe Not urgent

grantbuster commented 3 years ago

fixed in #333