NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

PySAM3 integration #386

Closed ppinchuk closed 2 years ago

ppinchuk commented 2 years ago

Only minor changes to tests - mostly just a new input key here or there or a light update to baseline values.

Pvwattsv7 default is deprecated in PySAM 3+, so the default class was removed, though Pvwattsv7 is still allowed to be used (indeed, all existing tests use "pvwattsv7" as the tech). Also added Pvwattsv8 as a new tech option.

Updated support to Python 3.10 including tests.

codecov-commenter commented 2 years ago

Codecov Report

Base: 80.48% // Head: 80.51% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (60de19a) compared to base (3e7fa69). Patch coverage: 75.86% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #386 +/- ## ========================================== + Coverage 80.48% 80.51% +0.02% ========================================== Files 142 142 Lines 19782 19804 +22 ========================================== + Hits 15922 15945 +23 + Misses 3860 3859 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `80.51% <75.86%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL/reV/pull/386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/generation/generation.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2dlbmVyYXRpb24vZ2VuZXJhdGlvbi5weQ==) | `85.79% <ø> (ø)` | | | [reV/supply\_curve/sc\_aggregation.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zY19hZ2dyZWdhdGlvbi5weQ==) | `79.17% <0.00%> (-1.02%)` | :arrow_down: | | [setup.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-c2V0dXAucHk=) | `0.00% <ø> (ø)` | | | [tests/test\_econ\_single\_owner.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9lY29uX3NpbmdsZV9vd25lci5weQ==) | `86.95% <ø> (-0.55%)` | :arrow_down: | | [reV/SAM/generation.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9nZW5lcmF0aW9uLnB5) | `93.52% <75.00%> (-0.12%)` | :arrow_down: | | [reV/SAM/\_\_init\_\_.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [reV/SAM/defaults.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9kZWZhdWx0cy5weQ==) | `75.20% <100.00%> (ø)` | | | [reV/version.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_gen\_linear.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fbGluZWFyLnB5) | `90.00% <100.00%> (-0.33%)` | :arrow_down: | | [tests/test\_gen\_pv.py](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fcHYucHk=) | `94.92% <100.00%> (+0.36%)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/NREL/reV/pull/386/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.